Fluid Typography: Use wp_ prefixed function #44876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
|
Seems to work fine. Gonna sudo-merge since we need this for the pending WP 6.1 RC1. |
|
Cherry-picked to |
This was referenced Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In dynamic blocks, use a
wp_prefixedwp_get_typography_font_size_valuerather than itsgutenberg_counterpart,gutenberg_get_typography_font_size_value.Why?
See WordPress/wordpress-develop#3437 (comment).
How?
Adding webpack logic to replace the prefix if needed.
Testing Instructions
Insert one of the affected blocks (Navigation Link, Navigation Submenu, Page List, Search) and set its font size. Save and view on the frontend. Confirm that it works, and no fatals are thrown.